Test-Path folders and remove

[localpct]

We have a collection of folders we get from a script, and the engineers don't like to keep this list up to date. I'm looking for a way to query if the folders exist, and if they do, add them to a new variable

Code: Select all

foreach ($folder in $Shares)
{
test-path $folder
if ($true){
$NewShares+= $folder;
}
}

The problem, my results are

\\share\folder\\share\folder2\\share\folder5

It's not breaking them into individual objects
What I'm looking at getting is

\\share\folder
\\share\folder2
\\share\folder5

[mxtrinidad]

You can create an array variable to store the result from the "foreach" statement.

[array] $myFolderlist = $null;

$myFolderlist = foreach ($folder in $Shares)
{
if ((test-path $folder) -eq $true){
$folder;
}
}

$myFolderlist

Hope this helps!

[localpct]

Yes it does.

Can I use this in a workflow? It would be much quicker to run through my list of 50 folders with a work flow. When I run the below script, it returns nothing

Code: Select all

Workflow TestWorkFlow{
foreach ($folder in $myFolderlist)
{test-path $folder}
}

[jvierra]

This is how to code this kind of coding pattern, PS will accumulate to an array automatically.

Code: Select all

$NewShares = foreach($folder in $Shares){
     if(test-path $folder){$folder}
}

Or even easier:

Code: Select all

$NewShares = $Shares | Where-Object{test-path $_}

A workflow will not give much speed with such short code.

[localpct]

Thanks to both of you. I have it working as I need it..

Just too bad workflows won't work :/

[jvierra]

Workflows will work. My indication is that they may not be all that much faster although this would depend on your network.

Here is an old script that I found in my junk box.

Code: Select all

workflow Test-WFConnection {
    param(
        [string[]]$Computers
    )

    foreach -parallel ($computer in $computers) {
        Test-Connection -ComputerName $computer -Count 1 -ErrorAction SilentlyContinue
    }

}

$computers = Get-ADComputer -Filter * | Select -Expand Name
Test-WFConnection $computers

[localpct]

Got it.. It's definitely not a significant increase. Thanks for taking the time to go back to this