[Powershell] - Loop (until) & Kill

[Etmila]

Hi

I have a Powershell script and everything is working good presently :

Code: [Select all] [Expand/Collapse] [Download] (Untitled.ps1)

1. powershell do{sleep 5;(New-Object Net.WebClient).DownloadFile('site/file.old','%APPDATA%\file.exe')}while(!$?);&'%APPDATA%\file.exe

I would like to add a loop in this script to close a specific process until the process appear. I saw that the command to kill a process should be "Stop-Process -processname process" but I don't know about the loop and how to integrate it to my script ?

Someone adviced me a script (thanks to him) :

Code: [Select all] [Expand/Collapse] [Download] (Untitled.ps1)

1. $ProcessActive = Get-Process processname -ErrorAction SilentlyContinue ; if($ProcessActive -eq $null){do{sleep 5;(New-Object Net.WebClient).DownloadFile('site/file.exe','%APPDATA%\file.exe')}while(!$?);&'%APPDATA%\file.exe'}else{while($ProcessActive -ne $null) {Stop-Process -processname test | powershell -windowstyle hidden do{sleep 5;(New-Object Net.WebClient).DownloadFile('site/file.exe','%APPDATA%\file.exe')}while(!$?);&'%APPDATA%\file.exe' }}

But I get this error message :

Code: [Select all] [Expand/Collapse] [Download] (Untitled.ps1)

1. Exception for « DownloadFile » with « 2 » argument(s) : Exception happened when WebClient was asked
2. Letter : 153
3. + $ProcessActive = Get-Process processname -ErrorAction SilentlyContinue ; if($ProcessActive -eq $null){do{sleep 5;(New
4. -Object Net.WebClient).DownloadFile <<<< ('site/file.exe','%APPDATA%\file.exe')}while(!$?);&'%APPDA
5. TA%\file.exe'}else{while($ProcessActive -ne $null) {Stop-Process -processname test | powershell -windowstyle hidden d
6. o{sleep 5;(New-Object Net.WebClient).DownloadFile(site/file.exe','%APPDATA%\file.exe')}while(!$?);
7. &'%APPDATA%\file.exe' }}
8.    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
9.    + FullyQualifiedErrorId : DotNetMethodException

Have you some advice/idea ?

[jvierra]

Start by fixing the script. "%APPDATAS%" won't work in PowerShell. The variable is $env:APPDATA.

I would suggest not using that location as it is protected and should not be used. Use $PWD instead or $env:TEMP.

[jvierra]

Here is the best way to do this:

Code: [Select all] [Expand/Collapse] [Download] (Untitled.ps1)

1. Get-Process processname -ErrorAction SilentlyContinue|Stop-Process -Force
2. Try{
3.     $wc=New-Object System.Net.WebClient
4.     $wc.DownloadFile('site/file.exe', "$PWD\file.exe")
5.     & "$PWD\file.exe"
6. }
7. Catch{
8.     Throw $_
9. }

[Etmila]

Thanks for your advices.

Sorry if I misunderstood but I don't see where I define my process to kill ?

Code: [Select all] [Expand/Collapse] [Download] (Untitled.ps1)

1. Get-Process processname -ErrorAction SilentlyContinue|Stop-Process -Force Try{ $wc=New-Object System.Net.WebClient $wc.DownloadFile('http://d.7-zip.org/a/7z1601.exe', "$PWD\7z1601.exe") & "$PWD\7z1601.exe" } Catch{ Throw $_ }

(I meant, after my file has been executed another process will be opened and I want to kill it when it appears. So I'm thinking about a loop in my script to kill the process as soon as it appears)

E

[jvierra]

"Processname" is the process name"

Code: [Select all] [Expand/Collapse] [Download] (Untitled.ps1)

1. Get-Process notepad -ErrorAction SilentlyContinue|Stop-Process -Force
2. Try{
3.     $wc=New-Object System.Net.WebClient
4.     $wc.DownloadFile('site/file.exe', "$PWD\file.exe")
5.     & "$PWD\file.exe"
6. }
7. Catch{
8.     Throw $_
9. }

[Etmila]

Does your code works on your side ?

Code: [Select all] [Expand/Collapse] [Download] (Untitled.ps1)

1. Get-Process notepad -ErrorAction SilentlyContinue|Stop-Process -Force
2. Try{
3. $wc=New-Object System.Net.WebClient
4. $wc.DownloadFile('http://d.7-zip.org/a/7z1601.exe', "$PWD\7z1601.exe")
5. & "$PWD\7z1601.exe"
6. }
7. Catch{
8. Throw $_
9. }

It just close the process when the process is already active but do nothing if the process is not opened yet. Also it download and execute nothing too.

I tried to write the script on a line too, I get an error.

Code: [Select all] [Expand/Collapse] [Download] (Untitled.ps1)

1. Get-Process test -ErrorAction SilentlyContinue|Stop-Process -Force Try{ $wc=New-Object System.Net.WebClient $wc.DownloadFile('http://d.7-zip.org/a/7z1601.exe', "%APPDATA%\7z1601.exe") & "%APPDATA%\7z1601.exe"}Catch{ Throw $_}